-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SharedIdSystem: return pubcid instead of sharedId #7149
Conversation
Cheers, looks good. I see another potential issue: it doesn't delete the stored id when |
@philipwatson In extendId() function, if optedout the id (cookie value) is set to undefined. |
@SKOCHERI But the core user module won’t use it if undefined. Here: https://github.com/SKOCHERI/Prebid.js/blob/32837f4c5d2247fb67286b1a95b462d733004d60/modules/userId/index.js#L662 |
@philipwatson The decode() is updated to handle output |
Yep that works. Cheers! |
* Sharedid fix * Sharedid fix * Sharedid fix * Sharedid fix * Sharedid fix * Sharedid fix * Sharedid fix * Sharedid fix * Fix test failure * Fix test failure * Fix test failure * Fix test failure * Fixing decode on optout Co-authored-by: skocheri <[email protected]>
This is for the issue reported in sharedIdSystem: return pubcid instead of sharedId #7099.
Apart from fixing the issue mentioned in sharedIdSystem: return pubcid instead of sharedId #7099. This PR has cleaned up the SharedIdSystem to removed calls to sharedId endpoint.