Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SharedIdSystem: return pubcid instead of sharedId #7149

Merged
merged 14 commits into from
Jul 20, 2021
Merged

SharedIdSystem: return pubcid instead of sharedId #7149

merged 14 commits into from
Jul 20, 2021

Conversation

SKOCHERI
Copy link
Contributor

@SKOCHERI SKOCHERI commented Jul 7, 2021 •
edited
Loading

@SKOCHERI SKOCHERI mentioned this pull request Jul 7, 2021
Merged
1 task
@ChrisHuie ChrisHuie self-requested a review July 8, 2021 08:13
@ChrisHuie ChrisHuie self-assigned this Jul 8, 2021
@philipwatson
Copy link
Contributor

Cheers, looks good.

I see another potential issue: it doesn't delete the stored id when _pubcid_optout cookie is detected.
So when the user opts-out after the stored id is created, prebid will keep using this stored id until it expires.

@SKOCHERI
Copy link
Contributor Author

SKOCHERI commented Jul 9, 2021

Cheers, looks good.

I see another potential issue: it doesn't delete the stored id when _pubcid_optout cookie is detected.
So when the user opts-out after the stored id is created, prebid will keep using this stored id until it expires.

@philipwatson In extendId() function, if optedout the id (cookie value) is set to undefined.

@philipwatson
Copy link
Contributor

@SKOCHERI But the core user module won’t use it if undefined. Here: https://github.com/SKOCHERI/Prebid.js/blob/32837f4c5d2247fb67286b1a95b462d733004d60/modules/userId/index.js#L662

@SKOCHERI
Copy link
Contributor Author

@SKOCHERI But the core user module won’t use it if undefined. Here: https://github.com/SKOCHERI/Prebid.js/blob/32837f4c5d2247fb67286b1a95b462d733004d60/modules/userId/index.js#L662

@philipwatson The decode() is updated to handle output

@philipwatson
Copy link
Contributor

Yep that works. Cheers!

@ChrisHuie ChrisHuie merged commit 42529cd into prebid:master Jul 20, 2021
@pycnvr pycnvr mentioned this pull request Nov 3, 2021
Closed
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
@SKOCHERI @agrandes-tappx
SharedIdSystem: return pubcid instead of sharedId (prebid#7149)
2995ede 
* Sharedid fix

* Sharedid fix

* Sharedid fix

* Sharedid fix

* Sharedid fix

* Sharedid fix

* Sharedid fix

* Sharedid fix

* Fix test failure

* Fix test failure

* Fix test failure

* Fix test failure

* Fixing decode on optout

Co-authored-by: skocheri <[email protected]>
@dgirardi dgirardi mentioned this pull request Nov 29, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHuie ChrisHuie ChrisHuie approved these changes

Assignees

@ChrisHuie ChrisHuie

Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SKOCHERI @philipwatson @ChrisHuie